Skip to content

[Backport release-25.05] victorialogs: init package and update module to revive victorialogs in 25.05#451137

Merged
leona-ya merged 13 commits intoNixOS:release-25.05from
Shawn8901:backport-vl
Oct 13, 2025
Merged

[Backport release-25.05] victorialogs: init package and update module to revive victorialogs in 25.05#451137
leona-ya merged 13 commits intoNixOS:release-25.05from
Shawn8901:backport-vl

Conversation

@Shawn8901
Copy link
Contributor

@Shawn8901 Shawn8901 commented Oct 11, 2025

In #450723 we backported victoriametrics to a recent version.
We oversaw that there is a breaking change hidden, that victorialogs (and vlagent), had been removed from the victoriametrics repository in version 1.222.0 (#427162 VictoriaMetrics/VictoriaMetrics@624497a , which is included in that version VictoriaMetrics/VictoriaMetrics@v1.121.0...v1.122.0 but not mentioned explicitly in the release notes, thus we overlooked it in the backport).

This Backport does fix the situation on default settings to bring back a victorialogs and companion package (vlagent) and updates the module in default to use the new package.
I included all version bumps.

IMHO that is the cleanest fix for the situation without reverting the version bump of victoriametrics.

see #450723 (comment) as ref.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

github-actions[bot]

This comment was marked as resolved.

NyCodeGHG and others added 13 commits October 11, 2025 23:23
(cherry picked from commit f2e8fd7)
(cherry picked from commit 3f9e587)
also migrate to new repository

(cherry picked from commit b46c0f2)
(cherry picked from commit 4faaa9a)
(cherry picked from commit 89cc4dc)
(cherry picked from commit 961847a)
(cherry picked from commit edf2ea1)
(cherry picked from commit c60ae6b)
(cherry picked from commit ef5a5f7)
(cherry picked from commit 41b3a62)
(cherry picked from commit cc9e523)
(cherry picked from commit 45b4661)
@github-actions github-actions bot dismissed their stale review October 11, 2025 21:25

All good now, thank you!

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 4.workflow: backport This targets a stable branch 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 11, 2025
@transcaffeine transcaffeine self-requested a review October 12, 2025 09:48
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 12, 2025
@leona-ya leona-ya added this pull request to the merge queue Oct 13, 2025
Merged via the queue into NixOS:release-25.05 with commit 1b3fb3b Oct 13, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants